Skip to content

Code and learn rollup 3 #23653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 9 commits into from
Closed

Code and learn rollup 3 #23653

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b29f4c0
test-http2-respond-file-fd-invalid: remove unused "e" from catch
Oct 12, 2018
c006bcb
test: inline common module boolean
ashleysimpson Oct 12, 2018
71f0c0e
test: remove unused variable from catch
Oct 12, 2018
60c0407
test: removed unused variable
Oct 12, 2018
b54dd17
test: fix assert.strictEqual params order
rockia Oct 12, 2018
8c8e883
test: change to arrow functions in send-bad-arguments
annatangzhao Oct 12, 2018
3743a72
lib: remove an unused variable
chenyil Oct 12, 2018
a0e7710
test: fix argument order for assert.strictEqual
inklin Oct 12, 2018
d2acacd
tls: update try catch syntax
UNLRN Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: removed unused variable 
Removed an unused variable in test-buffer-failed-alloc-typed-arrays.js.
  • Loading branch information
Michal Hynek @Trott
Michal Hynek authored and Trott committed Oct 14, 2018
commit 60c040752c058b1dc533a5465406ad6b441678c1
2 changes: 1 addition & 1 deletion test/parallel/test-buffer-failed-alloc-typed-arrays.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ for (const allocator of allocators) {
// These allocations are known to fail. If they do,
// Uint32Array should still produce a zeroed out result.
allocator(size);
} catch (e) {
} catch {
assert.deepStrictEqual(new Uint32Array(10), zeroArray);
}
}
Expand Down