Skip to content

test: fix assert.strictEqual params order #23480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rockia wants to merge 1 commit into from
Closed

test: fix assert.strictEqual params order #23480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix assert.strictEqual params order
  • Loading branch information
@rockia
rockia committed Oct 12, 2018
commit 946c9aa5cb5d5fab28b617cc6ddbf30306fbbff6
6 changes: 3 additions & 3 deletions test/sequential/test-pipe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const tcp = net.Server(common.mustCall((s) => {
s.on('data', (d) => {
tcpLengthSeen += d.length;
for (let j = 0; j < d.length; j++) {
assert.strictEqual(buffer[i], d[j]);
assert.strictEqual(d[j], buffer[i]);
i++;
}
});
Expand Down Expand Up @@ -103,7 +103,7 @@ function startClient() {
}, common.mustCall((res) => {
res.setEncoding('utf8');
res.on('data', common.mustCall((string) => {
assert.strictEqual('thanks', string);
assert.strictEqual(string, 'thanks');
gotThanks = true;
}));
}));
Expand All @@ -113,5 +113,5 @@ function startClient() {

process.on('exit', () => {
assert.ok(gotThanks);
assert.strictEqual(bufferSize, tcpLengthSeen);
assert.strictEqual(tcpLengthSeen, bufferSize);
});