Skip to content

doc: rewrite consensus seeking in guide #23349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
Closed

doc: rewrite consensus seeking in guide #23349

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
664a248
doc: rewrite consensus seeking in guide
Trott Oct 9, 2018
cf16b2c
fixup! doc: rewrite consensus seeking in guide
Trott Oct 11, 2018
4f4aea3
fixup! doc: rewrite consensus seeking in guide
Trott Oct 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! doc: rewrite consensus seeking in guide
  • Loading branch information
@Trott
Trott committed Oct 11, 2018
commit cf16b2c1f66ce6bf83fd925e1544a2566f45bef5
8 changes: 4 additions & 4 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,10 @@ Where there is disagreement among Collaborators, consensus should be sought if
possible. If reaching consensus is not possible, a Collaborator may escalate the
issue to the TSC.

Collaborators should not block pull requests without providing a reason. Other
Collaborators may ask objecting Collaborators questions about their objections.
If an objecting Collaborator is unresponsive, another Collaborator may dismiss
their objection.
Collaborators should not block a pull request without providing a reason.
Another Collaborator may ask an objecting Collaborator to explain their
objection. If the objector is unresponsive, another Collaborator may dismiss the
objection.

Note that [breaking changes](#breaking-changes) must receive

@jasnell jasnell Oct 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[Breaking](#breaking-changes) (`semver-major`) must receive
[TSC review](#involving-the-tsc). If two TSC members approve
the pull request and no Collaborators object, then it may land.
If there are objections, the TSC may be asked to give additional
consideration (by adding the `tsc-review` label), or the pull
request may be put on the TSC meeting agenda (by adding the
`tsc-agenda` label).

[TSC reviews](#involving-the-tsc). This does not mean that a Collaborator must
Expand Down