Skip to content

test: error when empty buffer is passed to filehandle.read() #23250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shisama wants to merge 3 commits into from
Closed

test: error when empty buffer is passed to filehandle.read() #23250

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea4b362
test: error when empty buffer is passed to filehandle.read()
Sep 30, 2018
464c83a
test: use async function for filehandle.read() test
Oct 4, 2018
41afe00
test: make error message aligned
Oct 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: use async function for filehandle.read() test
  • Loading branch information
Masashi Hirano
Masashi Hirano committed Oct 10, 2018
commit 464c83a324a5eec50ae4816f0649d364c8581ddb
5 changes: 3 additions & 2 deletions test/parallel/test-fs-read-empty-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ assert.throws(
}
);

fsPromises.open(filepath, 'r').then((filehandle) => {
(async () => {
const filehandle = await fsPromises.open(filepath, 'r');
assert.rejects(
() => filehandle.read(buffer, 0, 1, 0),
{
Expand All @@ -37,4 +38,4 @@ fsPromises.open(filepath, 'r').then((filehandle) => {
'Received Uint8Array []'
}
);
});
})();