Skip to content

process,tty: allow reading/writing from duplex sockets #23053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 7 commits into from
Closed

process,tty: allow reading/writing from duplex sockets #23053

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a4e4e48
Revert "tty: make _read throw ERR_TTY_WRITABLE_NOT_READABLE"
addaleax Sep 24, 2018
4467b66
tools: allow input for TTY tests
addaleax Sep 24, 2018
dd5b960
process: allow reading from stdout/stderr sockets
addaleax Sep 24, 2018
c39c8ac
test: add stdin writable regression test
addaleax Sep 24, 2018
5266788
fixup! process: allow reading from stdout/stderr sockets
addaleax Sep 24, 2018
2fb5f00
fixup! Revert "tty: make _read throw ERR_TTY_WRITABLE_NOT_READABLE"
addaleax Sep 24, 2018
df004fb
fixup! fixup! Revert "tty: make _read throw ERR_TTY_WRITABLE_NOT_READ…
addaleax Sep 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! Revert "tty: make _read throw ERR_TTY_WRITABLE_NOT_READ… 
…ABLE"
  • Loading branch information
@addaleax
addaleax committed Sep 24, 2018
commit df004fb9b750f186e464ccfdcb507360acc997ec
2 changes: 1 addition & 1 deletion doc/api/errors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2079,7 +2079,7 @@ An attempt has been made to create a string larger than the maximum allowed
size.

<a id="ERR_TTY_WRITABLE_NOT_READABLE"></a>
### ERR_TTY_WRITABLE_NOT_READABLE
#### ERR_TTY_WRITABLE_NOT_READABLE

This `Error` is thrown when a read is attempted on a TTY `WriteStream`,
such as `process.stdout.on('data')`.
Expand Down