Skip to content

io.js messaging #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikeal wants to merge 17 commits into from
Closed

io.js messaging #23

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
92598e8
node: Now working on v0.13.0
tjfontaine Aug 7, 2014
912b5e0
Merge remote-tracking branch 'upstream/v0.12'
tjfontaine Aug 7, 2014
7c04197
Merge remote-tracking branch 'upstream/v0.12'
tjfontaine Sep 17, 2014
25702ab
net: remove use of arguments in Server constructor
cjihrig Sep 24, 2014
f60abb0
First draft of a new contribution policy.
mikeal Oct 1, 2014
cfcb1de
stream: remove duplicated expression
yorkie Oct 2, 2014
051dc54
node: update links in CONTRIBUTING.md
cjihrig Oct 10, 2014
8c60aaa
node: add aliases to names in CONTRIBUTING.md
Fishrock123 Oct 10, 2014
7ee5c4e
node: outline invited persons and representatives
mikeal Oct 9, 2014
cafac11
node: refine TC percentage rules - CONTRIBUTING.md
Fishrock123 Oct 10, 2014
9116fcd
build: use %PYTHON% instead of python
rvagg Oct 16, 2014
6e99742
Merge remote-tracking branch 'joyent/master'
bnoordhuis Oct 29, 2014
0d8cbdf
Merge remote-tracking branch 'forward/v0.12'
bnoordhuis Oct 29, 2014
3cb5f3d
doc: meeting notes from oct 9th TC meeting
mikeal Oct 9, 2014
2c7847b
doc: add TC notes from october 29th
mikeal Oct 29, 2014
e7dec60
Said public when I meant private.
mikeal Oct 30, 2014
ba4b9f0
Some messaging in the README.
mikeal Dec 2, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
stream: remove duplicated expression 
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
  • Loading branch information
@yorkie @chrisdickinson
yorkie authored and chrisdickinson committed Oct 9, 2014
commit cfcb1de130867197cbc9c6012b7e84e08e53d032
6 changes: 3 additions & 3 deletions lib/_stream_readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,7 @@ function readableAddChunk(stream, state, chunk, encoding, addToFront) {
stream.emit('error', er);
} else if (chunk === null) {
state.reading = false;
if (!state.ended)
onEofChunk(stream, state);
onEofChunk(stream, state);
} else if (state.objectMode || chunk && chunk.length > 0) {
if (state.ended && !addToFront) {
var e = new Error('stream.push() after EOF');
Expand Down Expand Up @@ -387,7 +386,8 @@ function chunkInvalid(state, chunk) {


function onEofChunk(stream, state) {
if (state.decoder && !state.ended) {
if (state.ended) return;
if (state.decoder) {
var chunk = state.decoder.end();
if (chunk && chunk.length) {
state.buffer.push(chunk);
Expand Down