Skip to content

doc/api: clarify the documentation of pipes and zlib objects in them #22354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreasg123 wants to merge 3 commits into from
Closed

doc/api: clarify the documentation of pipes and zlib objects in them #22354

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72a9c89
doc/api: clarify the documentation of pipes and zlib objects in them
andreasg123 Aug 16, 2018
669dea8
doc/api: add link reference for stream.Transform
andreasg123 Aug 16, 2018
6729a7a
doc/api: list stream.Transform as another option for pipes
andreasg123 Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc/api: clarify the documentation of pipes and zlib objects in them 
Document how pipes can be chained in readable.pipe().
Document that zlib.Zlib inherits from stream.Transform.

Fixes: #22341
  • Loading branch information
@andreasg123
andreasg123 committed Aug 16, 2018
commit 72a9c899045e1ed8000810919c7ee5f9b7d97a26
4 changes: 2 additions & 2 deletions doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,8 +895,8 @@ added: v0.9.4
* `destination` {stream.Writable} The destination for writing data
* `options` {Object} Pipe options
* `end` {boolean} End the writer when the reader ends. **Default:** `true`.
* Returns: {stream.Writable} making it possible to set up chains of piped
streams
* Returns: {stream.Writable} The *destination*, allowing for a chain of pipes if
it is a [`Duplex`][] stream

@mcollina mcollina Aug 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add “or a Transform” - a reader might not know that Transform inherits from
Duplex.


The `readable.pipe()` method attaches a [`Writable`][] stream to the `readable`,
causing it to switch automatically into flowing mode and push all of its data
Expand Down
3 changes: 3 additions & 0 deletions doc/api/zlib.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,9 @@ added: v0.5.8
Not exported by the `zlib` module. It is documented here because it is the base
class of the compressor/decompressor classes.

This class inherits from [`stream.Transform`][], allowing `zlib` objects to be

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

@andreasg123 andreasg123 Aug 16, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Reference-style links were new to me.

used in pipes and similar stream operations.

### zlib.bytesRead
<!-- YAML
added: v8.1.0
Expand Down