Skip to content

lib: remove usc-2 encoding #21964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mscdex wants to merge 1 commit into from
Closed

lib: remove usc-2 encoding #21964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: remove usc-2 encoding 
Fixes: #21963
  • Loading branch information
@mscdex
mscdex committed Jul 25, 2018
commit fb50cf0e8cc04267a3b818d0e1bd5527d90f1626
8 changes: 3 additions & 5 deletions benchmark/util/normalize-encoding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,19 @@ const assert = require('assert');

const groupedInputs = {
group_common: ['undefined', 'utf8', 'utf-8', 'base64',
'binary', 'latin1', 'ucs-2', 'usc-2'],
'binary', 'latin1', 'ucs-2'],
group_upper: ['UTF-8', 'UTF8', 'UCS2', 'UTF-16LE',
'UTF16LE', 'BASE64', 'UCS-2', 'USC-2'],
'UTF16LE', 'BASE64', 'UCS-2'],
group_uncommon: ['foo', '1', 'false', 'undefined', '[]', '{}'],
group_misc: ['', 'utf16le', 'usc2', 'hex', 'HEX', 'BINARY']
group_misc: ['', 'utf16le', 'hex', 'HEX', 'BINARY']
};

const inputs = [
'',
'utf8', 'utf-8', 'UTF-8',
'UTF8', 'Utf8', 'uTf-8', 'utF-8',
'ucs2', 'UCS2', 'UcS2',
'USC2', 'usc2', 'uSc2',
'ucs-2', 'UCS-2', 'UcS-2',
'usc-2', 'USC-2', 'uSc-2',
'utf16le', 'utf-16le', 'UTF-16LE', 'UTF16LE',
'binary', 'BINARY', 'latin1', 'base64', 'BASE64',
'hex', 'HEX', 'foo', '1', 'false', 'undefined', '[]', '{}'];
Expand Down
1 change: 0 additions & 1 deletion lib/internal/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ function slowCases(enc) {
enc = `${enc}`.toLowerCase();
if (enc === 'utf-8') return 'utf8';
if (enc === 'ascii') return 'ascii';
if (enc === 'usc-2') return 'utf16le';
if (enc === 'ucs-2') return 'utf16le';
break;
case 6:
Expand Down
3 changes: 0 additions & 3 deletions test/parallel/test-internal-util-normalizeencoding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ const tests = [
['utf-16le', 'utf16le'],
['UTF-16LE', 'utf16le'],
['UTF16LE', 'utf16le'],
['usc-2', 'utf16le'],
['USC-2', 'utf16le'],
['uSc-2', 'utf16le'],
['binary', 'latin1'],
['BINARY', 'latin1'],
['latin1', 'latin1'],
Expand Down