Skip to content

doc: add missing worker error #21947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjamingr wants to merge 3 commits into from
Closed

doc: add missing worker error #21947

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
959d342
doc: add missing worker error
Jul 23, 2018
c82fc76
fixup! better phrasing for the comment.
benjamingr Jul 23, 2018
8a5ff77
fixup! style nits
benjamingr Jul 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: add missing worker error 
ERR_TRANSFERRING_EXTERNALIZED_SHAREDARRAYBUFFER was missing from the
docs - add it there based on the wording Anna used in the her PR.

PR-URL:
Reviewed-By:
  • Loading branch information
Benjamin Gruenbaum
Benjamin Gruenbaum committed Jul 23, 2018
commit 959d3421ba43fdf7bf868c9ddeff226fa0e69525
7 changes: 7 additions & 0 deletions doc/api/errors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1669,6 +1669,13 @@ category.
The `trace_events` module could not be loaded because Node.js was compiled with
the `--without-v8-platform` flag.

<a id="ERR_TRANSFERRING_EXTERNALIZED_SHAREDARRAYBUFFER"></a>
### ERR_TRANSFERRING_EXTERNALIZED_SHAREDARRAYBUFFER

A SharedArrayBuffer object was transfered but we do not see a lifetime partner
object and it was not us who externalized it - we are not sure how to serialize
it because it's unclear how the memory is actually owned.

@addaleax addaleax Jul 23, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description makes sense as a code comment, but it might not be ideal for the docs. How about this?

A SharedArrayBuffer object was encountered during serialization whose memory is not managed by the JavaScript engine or by Node. Such an SharedArrayBuffer can not be serialized.

This can only happen when native addons create SharedArrayBuffers in “externalized” mode, or put existing SharedArrayBuffer into externalized mode.

@benjamingr benjamingr Jul 23, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds good.


<a id="ERR_TRANSFORM_ALREADY_TRANSFORMING"></a>
### ERR_TRANSFORM_ALREADY_TRANSFORMING

Expand Down