Skip to content

doc: initial cut at support tiers for diag tools #21870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 9 commits into from
Closed

doc: initial cut at support tiers for diag tools #21870

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
19ee126
doc: initial cut at support tiers for diag tools
mhdawson Jul 18, 2018
345d17f
squash: partially address first set of comments
mhdawson Aug 7, 2018
57bef97
squash: address more comments
mhdawson Aug 7, 2018
19120b2
squash: address additional comments.
mhdawson Aug 7, 2018
c31bf8a
squash: address additional comments
mhdawson Aug 7, 2018
ee6b81d
squash: address rest of comments
mhdawson Aug 7, 2018
bb4ec69
squash: address comments
mhdawson Aug 8, 2018
1e46bd3
squash: fix linting issues from comments
mhdawson Aug 9, 2018
11bd549
squash: address comments
mhdawson Aug 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: address comments
  • Loading branch information
@mhdawson
mhdawson committed Aug 27, 2018
commit bb4ec69a919a7b3e066dfbeb490ed51b2cfe3439
7 changes: 4 additions & 3 deletions doc/guides/diagnostic-tooling-support-tiers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,15 @@ the following tiers.
suite for the tool/API is not green. To be considered for inclusion
in this tier it must have a good test suite and that test suite and a job

@joyeecheung joyeecheung Jul 22, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we include entries similar to those required by citgm:

The maintainers of the module remain responsive when there are problems
The module must be actively used by the community
The module must be heavily depended on

Given that tier-one tools block our commits and releases.

must exist in the Node.js CI so that it can be run as part of the release
process. No commit to master should break this tool/API if the next
major release is within 1 month. In addition:
process. Tests on master will be run nightly when possible to provide early warning
of potential issues. No commit to the current and LTS release branches should break this
tool/API if the next major release is within 1 month. In addition:
* The maintainers of the tool must remain responsive when there are problems;
* The tool must be actively used by the ecosystem;
* The tool must be heavily depended on;
* The tool must have a guide or other documentation in the Node.js GitHub
organization or website;
* The tool must be work on all supported platforms;
* The tool must be working on all supported platforms;
* The tool must only be using APIs exposed by Nodejs as opposed to
its dependencies; and
* The tool must be open source.
Expand Down