Skip to content

test,doc: address http2 connection abort/network error handling #21861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

test,doc: address http2 connection abort/network error handling #21861

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f998d9
test: fix http2 connection abort test
addaleax Jul 17, 2018
4df7e81
doc: document http2 network error behaviour
addaleax Jul 17, 2018
65c8643
fixup! doc: document http2 network error behaviour
addaleax Jul 18, 2018
fd8a861
fixup! doc: document http2 network error behaviour
addaleax Jul 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: fix http2 connection abort test 
Refs: #21836
Refs: #21561
  • Loading branch information
@addaleax
addaleax committed Jul 17, 2018
commit 7f998d92e6c7746ae6bb96b73c26a19188a82d48
11 changes: 3 additions & 8 deletions test/parallel/test-http2-respond-with-file-connection-abort.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');
const net = require('net');

Expand All @@ -12,6 +13,7 @@ const {

const server = http2.createServer();
server.on('stream', common.mustCall((stream) => {
stream.on('error', (err) => assert.strictEqual(err.code, 'ECONNRESET'));
stream.respondWithFile(process.execPath, {
[HTTP2_HEADER_CONTENT_TYPE]: 'application/octet-stream'
});
Expand All @@ -22,16 +24,9 @@ server.listen(0, common.mustCall(() => {
const req = client.request();

req.on('response', common.mustCall(() => {}));
req.on('data', common.mustCall(() => {
req.on('data', common.mustCallAtLeast(() => {
net.Socket.prototype.destroy.call(client.socket);
server.close();
}));
req.end();
}));

// TODO(addaleax): This is a *hack*. HTTP/2 needs to have a proper way of
// dealing with this kind of issue.
process.once('uncaughtException', (err) => {
if (err.code === 'ECONNRESET') return;
throw err;
});