Skip to content

[v8.x backport] http: do not rely on the 'agentRemove' event #21734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lpinca wants to merge 5 commits into from
Closed

[v8.x backport] http: do not rely on the 'agentRemove' event #21734

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b57ad02
deps: V8: backport 14 CPU profiler commits from upstream
psmarshall Jun 26, 2018
71a8f6c
doc: remove ES6/ECMAScript 2015 from buffer.md
Trott Mar 29, 2018
23ca557
doc: Uint8Array support in Buffer functions
SheetJSDev Apr 12, 2018
a6299d6
test: make test-error-reporting engine agnostic
Trott Oct 17, 2017
11333c2
http: do not rely on the 'agentRemove' event
lpinca May 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: Uint8Array support in Buffer functions 
Buffer.from / new Buffer accept Uint8Array

Fixes: #14118

Backport-PR-URL: #21590
PR-URL: #19949
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
  • Loading branch information
@SheetJSDev @MylesBorins
SheetJSDev authored and MylesBorins committed Jul 9, 2018
commit 23ca5575320c94f5518987ec3aff20fd48bda0cf
5 changes: 2 additions & 3 deletions doc/api/buffer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@

Prior to the introduction of [`TypedArray`], the JavaScript language had no
mechanism for reading or manipulating streams of binary data. The `Buffer` class
was introduced as part of the Node.js API to make it possible to interact with
octet streams in the context of things like TCP streams and file system
operations.
was introduced as part of the Node.js API to enable interaction with octet
streams in TCP streams, file system operations, and other contexts.

With [`TypedArray`] now available, the `Buffer` class implements the
[`Uint8Array`] API in a manner that is more optimized and suitable for Node.js.
Expand Down