Skip to content

http: fix request with option timeout and agent #21204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
killagu wants to merge 7 commits into from
Closed

http: fix request with option timeout and agent #21204

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
33e62a1
http: fix request with option timeout and agent
killagu Jun 8, 2018
4add8f6
update tests
killagu Jun 11, 2018
7ab62fb
minor edit to doc text
Trott Jun 11, 2018
9773531
fixup! minor edit to comment text
Trott Jun 11, 2018
3b30906
squash! minor edit to comment
Trott Jun 11, 2018
1cf617e
squash! minor edits to comments
Trott Jun 11, 2018
2c5f0c0
squash! minor edits to comments
Trott Jun 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash! minor edits to comments
  • Loading branch information
@Trott
Trott authored Jun 11, 2018
commit 2c5f0c05bbedbf6647c436a90aa25ee4b3c60997
12 changes: 6 additions & 6 deletions test/parallel/test-http-client-timeout-option-with-agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

@Trott Trott Jun 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be willing to add a comment here explaining what this is testing?

const common = require('../common');

// This test ensure http request with timeout and agent,
// Test that when http request uses both timeout and agent,
// timeout will work as expected.

const assert = require('assert');
Expand All @@ -21,7 +21,7 @@ const options = {
};

const server = http.createServer(() => {
// never response
// Never respond.
});

server.listen(0, options.host, function() {
Expand All @@ -33,23 +33,23 @@ function doRequest() {
const req = http.request(options);
const start = Date.now();
req.on('error', () => {
// this space is intentionally left blank
// This space is intentionally left blank.
});
req.on('close', common.mustCall(() => server.close()));

let timeout_events = 0;
req.on('timeout', common.mustCall(() => {
timeout_events += 1;
const duration = Date.now() - start;
// The timeout event can not be accurately fired, It will delay
// in some milliseconds, so test it in second units.
// The timeout event cannot be precisely timed. It will delay
// some number of milliseconds, so test it in second units.
assert.strictEqual(duration / 1000 | 0, HTTP_CLIENT_TIMEOUT / 1000);
}));
req.end();

setTimeout(function() {
req.destroy();
assert.strictEqual(timeout_events, 1);
// Ensure the `timeout` be event fired only once.
// Ensure the `timeout` event fired only once.
}, common.platformTimeout(HTTP_CLIENT_TIMEOUT * 2));
}