Skip to content

doc: add note about autocrlf required for tests #20752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bzoz wants to merge 2 commits into from
Closed

doc: add note about autocrlf required for tests #20752

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b618931
doc: add note about autocrlf required for tests
bzoz May 15, 2018
91c05a5
fixup: test -> tests
bzoz May 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: add note about autocrlf required for tests 
Adds a note to test/README.md that setting autocrlf to true when
checking out sources is required for the tests to run successfully.

Ref: #18967
  • Loading branch information
@bzoz
bzoz committed May 15, 2018
commit b618931c43b13ab8521d0a4d59649080cabd240b
3 changes: 3 additions & 0 deletions test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ directory, see [the guide on writing tests](../doc/guides/writing-tests.md).
On how to run tests in this directory, see
[the contributing guide](../doc/guides/contributing/pull-requests.md#step-6-test).

For the test to successfully run on Windows, Node.js has to be checked out from

@Trott Trott May 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: test -> tests?

@bzoz bzoz May 16, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I'll fix it

GitHub with the `autocrlf` git config flag set to true.

## Test Directories

|Directory |Runs on CI |Purpose |
Expand Down