Skip to content

test: remove message from strictEqual assertions #20174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bryancr89 wants to merge 1 commit into from
Closed

test: remove message from strictEqual assertions #20174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove message from strictEqual assertions 
When an AssertionError happens, the value of headers['set-cookie']
is not reported. That information is useful for debugging.
Hence removed the value passed as the message in deepStrictEqual assertions
of test/parallel/test-http2-cookies.js
  • Loading branch information
@bryancr89
bryancr89 committed Apr 20, 2018
commit 5d109bd5a053850e4024301cf3f97d8340f571ae
3 changes: 1 addition & 2 deletions test/parallel/test-http2-cookies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ server.on('listening', common.mustCall(() => {

req.on('response', common.mustCall((headers) => {
assert(Array.isArray(headers['set-cookie']));
assert.deepStrictEqual(headers['set-cookie'], setCookie,
'set-cookie header does not match');
assert.deepStrictEqual(headers['set-cookie'], setCookie);
}));

req.on('end', common.mustCall(() => {
Expand Down