Skip to content

src: assign ERR_SCRIPT_EXECUTION_* codes in C++ #20147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 2 commits into from
Closed

src: assign ERR_SCRIPT_EXECUTION_* codes in C++ #20147

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56a6434
src: assign ERR_SCRIPT_EXECUTION_* codes in C++
joyeecheung Apr 19, 2018
83e5f70
fixup! src: assign ERR_SCRIPT_EXECUTION_* codes in C++
joyeecheung Apr 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: assign ERR_SCRIPT_EXECUTION_* codes in C++
  • Loading branch information
@joyeecheung
joyeecheung committed Apr 23, 2018
commit 83e5f70c4d80a1c5ee189adddc0c9f978be9a9e3
12 changes: 7 additions & 5 deletions src/node_errors.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
#include "env-inl.h"
#include "v8.h"

#include <inttypes.h>
// Use ostringstream to print exact-width integer types
// because the format specifiers are not available on AIX.
#include <sstream>

namespace node {

Expand Down Expand Up @@ -70,10 +72,10 @@ namespace node {
// Errors with predefined non-static messages
inline void THROW_ERR_SCRIPT_EXECUTION_TIMEOUT(Environment* env,
int64_t timeout) {
char message[128];
snprintf(message, sizeof(message),
"Script execution timed out after %" PRId64 "ms", timeout);
THROW_ERR_SCRIPT_EXECUTION_TIMEOUT(env, message);
std::ostringstream message;
message << "Script execution timed out after ";
message << timeout << "ms";
THROW_ERR_SCRIPT_EXECUTION_TIMEOUT(env, message.str().c_str());
}

inline v8::Local<v8::Value> ERR_BUFFER_TOO_LARGE(v8::Isolate *isolate) {
Expand Down