Skip to content

doc: add changes entry for vm code generation options #19440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomCoded wants to merge 2 commits into from
Closed

doc: add changes entry for vm code generation options #19440

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3f9a0b
doc: add changes entry for vm code generation options
TomCoded Mar 19, 2018
7ee1875
doc: fix indentation of new changes for vm code generation options
TomCoded Mar 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions doc/api/vm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,10 @@ overhead.
### script.runInNewContext([sandbox[, options]])
<!-- YAML
added: v0.3.1
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/19016
description: The `contextCodeGeneration` option is supported now.

@lpinca lpinca Mar 19, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please keep this aligned with pr-url? Shift left by 4 spaces.

-->

* `sandbox` {Object} An object that will be [contextified][]. If `undefined`, a
Expand Down Expand Up @@ -573,6 +577,10 @@ console.log(globalVar);
## vm.createContext([sandbox[, options]])
<!-- YAML
added: v0.3.1
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/19016
description: The `codeGeneration` option is supported now.

@lpinca lpinca Mar 19, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

-->

* `sandbox` {Object}
Expand Down