Skip to content

child_process: define EACCES as a runtime error #19294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gireeshpunathil wants to merge 1 commit into from
Closed

child_process: define EACCES as a runtime error #19294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
child_process: define EACCES as a runtime error 
Access permission on the target child is currently thrown
as an exception. Bring this under the runtime error definition,
much like ENOENT and friends.

Fixes: nodejs/help#990
  • Loading branch information
@gireeshpunathil
gireeshpunathil committed Mar 12, 2018
commit 07b7b2ea480a9c405bd8841ed02c429a0a96ea16
4 changes: 3 additions & 1 deletion lib/internal/child_process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const { isUint8Array } = require('internal/util/types');
const spawn_sync = process.binding('spawn_sync');

const {
UV_EACCES,
UV_EAGAIN,
UV_EINVAL,
UV_EMFILE,
Expand Down Expand Up @@ -315,7 +316,8 @@ ChildProcess.prototype.spawn = function(options) {
var err = this._handle.spawn(options);

// Run-time errors should emit an error, not throw an exception.
if (err === UV_EAGAIN ||
if (err === UV_EACCES ||
err === UV_EAGAIN ||
err === UV_EMFILE ||
err === UV_ENFILE ||
err === UV_ENOENT) {
Expand Down