Skip to content

src: prevent persistent handle resource leaks #18656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnoordhuis merged 3 commits into from
Feb 21, 2018
Merged

src: prevent persistent handle resource leaks #18656

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
992703f
src: prevent persistent handle resource leaks
bnoordhuis Feb 21, 2018
d402481
src: remove unnecessary Reset() calls
bnoordhuis Feb 21, 2018
6bdc18c
src: don't touch js object in Http2Session dtor
bnoordhuis Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: don't touch js object in Http2Session dtor 
Don't try to update the internal field pointer of the JS object in the
destructor.

The garbage collector invokes the destructor when the object is
collected and is not necessarily in a valid state anymore.

PR-URL: #18656
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information
@bnoordhuis
bnoordhuis committed Feb 21, 2018
commit 6bdc18c592b9d66fd652a9bdaa53f87486d0a634
2 changes: 0 additions & 2 deletions src/node_http2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,8 +531,6 @@ Http2Session::Http2Session(Environment* env,

Http2Session::~Http2Session() {
CHECK_EQ(flags_ & SESSION_STATE_HAS_SCOPE, 0);
if (!object().IsEmpty())
ClearWrap(object());
DEBUG_HTTP2SESSION(this, "freeing nghttp2 session");
nghttp2_session_del(session_);
}
Expand Down