Skip to content

test: fix flaky test-http2-session-unref #18589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apapirovski wants to merge 1 commit into from
Closed

test: fix flaky test-http2-session-unref #18589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix flaky test-http2-session-unref 
This test should exit naturally or will timeout on its own,
a separate unrefed timer is not necessary.
  • Loading branch information
@apapirovski
apapirovski committed Feb 5, 2018
commit 9124af620af3592530b20b368316db15872101f4
2 changes: 0 additions & 2 deletions test/parallel/test-http2-session-unref.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,3 @@ server.listen(0, common.mustCall(() => {
}));
server.emit('connection', serverSide);
server.unref();

setTimeout(common.mustNotCall(() => {}), 1000).unref();