Skip to content

build: add node_lib_target_name to cctest deps #18576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 4 commits into from
Closed

build: add node_lib_target_name to cctest deps #18576

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d39cbf9
build: add node_lib_target_name to cctest deps
danbev Feb 5, 2018
9fc08af
squash: add extern declarations for constants
danbev Feb 14, 2018
15051d3
squash: re-add rename_node_bin_win to cctest deps
danbev Feb 14, 2018
d76100c
squash: add extern "C" to global vars
danbev Feb 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: add extern "C" to global vars 
It seems that these are not linked properly on Windows with out this.
  • Loading branch information
@danbev
danbev committed Feb 16, 2018
commit d76100caf0f569f19762fa93bbf27083b2d5fe42
2 changes: 2 additions & 0 deletions test/cctest/test_node_postmortem_metadata.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include "v8.h"
#include "v8abbr.h"

extern "C" {
extern uintptr_t
nodedbg_offset_HandleWrap__handle_wrap_queue___ListNode_HandleWrap;
extern uintptr_t
Expand All @@ -25,6 +26,7 @@ extern uintptr_t
nodedbg_offset_Environment_ReqWrapQueue__head___ListNode_ReqWrapQueue;
extern uintptr_t
nodedbg_offset_BaseObject__persistent_handle___v8_Persistent_v8_Object;
}


class DebugSymbolsTest : public EnvironmentTestFixture {};
Expand Down