Skip to content

test: suppress unused warning postmortem_metadata #18557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 1 commit into from
Closed

test: suppress unused warning postmortem_metadata #18557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: suppress unused warning postmortem_metadata 
Currently the following warning is generated by when building the
cctests:
../test/cctest/test_node_postmortem_metadata.cc:133:13:
warning: unused variable 'it' [-Wunused-variable]
  for (auto it : *(*env)->req_wrap_queue()) {}
            ^
1 warning generated.

This commmit adds a cast to void to suppres the warning.
  • Loading branch information
@danbev
danbev committed Feb 4, 2018
commit 3b3104341971cfd910d4da641610a710b2ee80ca
2 changes: 1 addition & 1 deletion test/cctest/test_node_postmortem_metadata.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ TEST_F(DebugSymbolsTest, ReqWrapList) {
// NOTE (mmarchini): Workaround to fix failing tests on ARM64 machines with
// older GCC. Should be removed once we upgrade the GCC version used on our
// ARM64 CI machinies.
for (auto it : *(*env)->req_wrap_queue()) {}
for (auto it : *(*env)->req_wrap_queue()) { (void) it; }

auto queue = reinterpret_cast<uintptr_t>((*env)->req_wrap_queue());
auto head = queue +
Expand Down