Skip to content

stream: always reset awaitDrain when emitting data #18516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
addaleax merged 2 commits into from
Feb 6, 2018
Merged

stream: always reset awaitDrain when emitting data #18516

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7cb694
stream: always reset awaitDrain when emitting data
addaleax Feb 2, 2018
ee67dd0
test: add test for stream unpipe with 'data' listeners
addaleax Feb 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add test for stream unpipe with 'data' listeners 
PR-URL: #18516
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
@addaleax
addaleax committed Feb 6, 2018
commit ee67dd0a47b2fd5c1dd062349bdfccd5e2e0681a
29 changes: 29 additions & 0 deletions test/parallel/test-stream-pipe-flow-after-unpipe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
'use strict';
const common = require('../common');
const { Readable, Writable } = require('stream');

// Tests that calling .unpipe() un-blocks a stream that is paused because
// it is waiting on the writable side to finish a write().

const rs = new Readable({
highWaterMark: 1,
// That this gets called at least 20 times is the real test here.
read: common.mustCallAtLeast(() => rs.push('foo'), 20)
});

const ws = new Writable({
highWaterMark: 1,
write: common.mustCall(() => {
// Ignore the callback, this write() simply never finishes.
setImmediate(() => rs.unpipe(ws));
})
});

let chunks = 0;
rs.on('data', common.mustCallAtLeast(() => {
chunks++;
if (chunks >= 20)
rs.pause(); // Finish this test.
}));

rs.pipe(ws);