Skip to content

http, timers: remove domain specific code #18477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apapirovski wants to merge 2 commits into from
Closed

http, timers: remove domain specific code #18477

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d442a9c
http: remove domain specific code
apapirovski Jan 29, 2018
8cfa05d
timers: remove domain specific code
apapirovski Jan 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
http: remove domain specific code 
Due to some changes to async tracking of http and also
in how domains are handled, it's no logner necessary
to manually copy domain from req to res in http code.
  • Loading branch information
@apapirovski
apapirovski committed Jan 31, 2018
commit d442a9c5b16804b4591dc020780fcf9c2723651c
6 changes: 0 additions & 6 deletions lib/_http_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,12 +458,6 @@ function parserOnIncomingClient(res, shouldKeepAlive) {
var socket = this.socket;
var req = socket._httpMessage;

// propagate "domain" setting...
if (req.domain && !res.domain) {
debug('setting "res.domain"');
res.domain = req.domain;
}

debug('AGENT incoming response!');

if (req.res) {
Expand Down