Skip to content

benchmark: rest operator benchmark #18442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 2 commits into from
Closed

benchmark: rest operator benchmark #18442

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d947fa
benchmark: rest operator benchmark
jasnell Jan 29, 2018
61b67bc
[Squash] Nits
jasnell Feb 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
benchmark: rest operator benchmark 
Benchmark comparing `util._extend()`, `Object.assign()`,
and the rest operator for object assignment.

`util._extend()` still wins currently.
  • Loading branch information
@jasnell
jasnell committed Feb 1, 2018
commit 8d947fa3ee39630c8da3e5fdc70632998fe76146
47 changes: 47 additions & 0 deletions benchmark/es/rest-assign.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
'use strict';

const common = require('../common.js');
const assert = require('assert');
const util = require('util');

const bench = common.createBenchmark(main, {
method: ['rest', 'assign', '_extend'],

@vsemozhetbyt vsemozhetbyt Jan 30, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_extend -> extend, otherwise Error: Unexpected method

count: [5, 10, 20],
millions: [1]
});

function main({ millions, context, count, rest, method }) {
const n = millions * 1e6;

const src = {};
for (let n = 0; n < count; n++)
src[`p${n}`] = n;

let obj;
let i;

switch (method) {
case '':
// Empty string falls through to next line as default, mostly for tests.
case 'extend':
bench.start();
for (i = 0; i < n; i++)
obj = util._extend({}, src);
bench.end(n);
break;
case 'assign':
bench.start();
for (i = 0; i < n; i++)
obj = Object.assign({}, src);
bench.end(n);
break;
case 'rest':
bench.start();
for (i = 0; i < n; i++)
obj = { ...src };
bench.end(n);
break;
default:
throw new Error('Unexpected method');
}
}