Skip to content

Refloat cherry-picks from #18196 #18360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ofrobots wants to merge 3 commits into from
Closed

Refloat cherry-picks from #18196 #18360

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5bbf90
deps: cherry-pick 814577e from upstream V8
ofrobots Jan 17, 2018
ee5a37b
deps: cherry-pick c3bb73f from upstream V8
ofrobots Jan 17, 2018
20c1fce
deps: V8: reintroduce missing whitespace in test
ofrobots Jan 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
deps: V8: reintroduce missing whitespace in test 
4c4af64 accidentally dropped the significant whitespace from this test
when it was landed. Add the whitespace back.

Refs: #17489
PR-URL: #18360
  • Loading branch information
@ofrobots
ofrobots committed Jan 25, 2018
commit 20c1fceba2b84383a396cec9ce010439239c35ab
9 changes: 5 additions & 4 deletions deps/v8/test/cctest/interpreter/bytecode_expectations/ClassFields.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ snippet: "
static c;
static ['d'];
}

class B {
a = 1;
['b'] = this.a;
Expand Down Expand Up @@ -138,7 +138,7 @@ snippet: "
static c;
static ['d'];
}

class B extends class {} {
a = 1;
['b'] = this.a;
Expand All @@ -149,7 +149,7 @@ snippet: "
super();
}
}

class C extends B {
a = 1;
['b'] = this.a;
Expand All @@ -159,7 +159,7 @@ snippet: "
(() => super())();
}
}

new A;
new B;
new C;
Expand Down Expand Up @@ -335,3 +335,4 @@ constant pool: [
]
handlers: [
]