Skip to content

doc: document the collaborator nomination process #18268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 5 commits into from
Closed

doc: document the collaborator nomination process #18268

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ba2c04
doc: improve the instructions of onboarding PR
joyeecheung Jan 20, 2018
acbdfd7
doc: document the collaborator nomination process
joyeecheung Jan 20, 2018
81c6801
fixup! avoid ambiguity in pronouns
joyeecheung Jan 20, 2018
037976a
fixup! fix broken link in onboarding.md
joyeecheung Jan 22, 2018
6424d8c
improve phrasing, capitalize Collaborator
joyeecheung Jan 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! avoid ambiguity in pronouns
  • Loading branch information
@joyeecheung
joyeecheung committed Jan 20, 2018
commit 81c68017812953356dcdeb3dd1dc7733065249e7
7 changes: 4 additions & 3 deletions GOVERNANCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ not limited to:
* Commits in the [nodejs/node][] repository.
* Can be shown using the link
`https://github.com/nodejs/node/commits?author=${GITHUB_ID}`
(replace `${GITHUB_ID}` with their GitHub ID).
(replace `${GITHUB_ID}` with the nominee's GitHub ID).
* Pull requests and issues opened in the [nodejs/node][] repository.
* Can be shown using the link
`https://github.com/nodejs/node/pulls?q=author%3A${GITHUB_ID}+`
Expand Down Expand Up @@ -179,8 +179,9 @@ objections from any TSC members.
Prior to the public nomination, the collaborator initiating it can seek
feedback from other collaborators in private using
[the GitHub discussion page][collaborators-discussions] of the
collaborators team, and work with the nominee to improve their contribution
profile, in order to make the nomination as frictionless as possible.
collaborators team, and work with the nominee to improve the nominee's
contribution profile, in order to make the nomination as frictionless
as possible.

If individuals making valuable contributions do not believe they have been
considered for a nomination, they may log an issue or contact a collaborator
Expand Down