Skip to content

doc: suggest not to throw JS errors from C++ #18149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 3 commits into from
Closed

doc: suggest not to throw JS errors from C++ #18149

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccfd2b1
doc: suggest not to throw JS errors from C++
joyeecheung Jan 14, 2018
877afe1
[squash] fix typo
joyeecheung Jan 14, 2018
d42a2b5
[squash] mention C++ CHECKs, fix examples
joyeecheung Jan 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] fix typo
  • Loading branch information
@joyeecheung
joyeecheung committed Jan 14, 2018
commit 877afe10649e1c6dac06b408513a83e374db24da
2 changes: 1 addition & 1 deletion CPP_STYLE_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ When there is a need to throw errors from a C++ binding method, try to
return the data necessary for constructing the errors to JavaScript,
then construct and throw the errors [using `lib/internal/errors.js`][errors].

Note that in general, type-checks on arguments should done in JavaScript
Note that in general, type-checks on arguments should be done in JavaScript
before the arguments are passed into C++.

@jasnell jasnell Jan 14, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add something about including a CHECK at the C++ level?


If the return value of the binding cannot be used to signal failures or return
Expand Down