Skip to content

test: simplify test-buffer-slice.js #17962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
starkwang wants to merge 2 commits into from
Closed

test: simplify test-buffer-slice.js #17962

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
973e27e
test: simplify test-buffer-slice.js
starkwang Jan 3, 2018
a914fbf
[squash]change into buf.toString()
starkwang Jan 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash]change into buf.toString()
  • Loading branch information
@starkwang
starkwang committed Jan 4, 2018
commit a914fbfb54ceaf570c32ed7896224b6b10c6cac7
10 changes: 5 additions & 5 deletions test/parallel/test-buffer-slice.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,12 @@ const expectedSameBufs = [
[buf.slice('0', '-111'), Buffer.from('', 'utf8')]
];

for (let i = 0, s = buf; i < buf.length; ++i) {
for (let i = 0, s = buf.toString(); i < buf.length; ++i) {
expectedSameBufs.push(
[buf.slice(i), s.slice(i)],
[buf.slice(0, i), s.slice(0, i)],
[buf.slice(-i), s.slice(-i)],
[buf.slice(0, -i), s.slice(0, -i)]
[buf.slice(i), Buffer.from(s.slice(i))],
[buf.slice(0, i), Buffer.from(s.slice(0, i))],
[buf.slice(-i), Buffer.from(s.slice(-i))],
[buf.slice(0, -i), Buffer.from(s.slice(0, -i))]
);
}

Expand Down