Skip to content

src: minor refactoring to StreamBase #17564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

src: minor refactoring to StreamBase #17564

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e88eba
src: remove `StreamResourc::Cast()`
addaleax Dec 9, 2017
cf96acc
src: minor refactoring to StreamBase writes
addaleax Dec 9, 2017
2c08345
[squash] make CI happy
addaleax Dec 9, 2017
0f28644
test: expand test-https-keep-alive-large-write
addaleax Dec 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: expand test-https-keep-alive-large-write 
Check that `serverConnectionHandle.writeQueueSize === 0`
after a large write finished.
  • Loading branch information
@addaleax
addaleax committed Dec 9, 2017
commit 0f2864422fb422b646c82fcc99e497371a329562
4 changes: 3 additions & 1 deletion test/sequential/test-https-keep-alive-large-write.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ const server = https.createServer({
});

serverConnectionHandle = res.socket._handle;
res.write(content);
res.write(content, () => {
assert.strictEqual(serverConnectionHandle.writeQueueSize, 0);
});
res.end();
}));
server.setTimeout(serverTimeout);
Expand Down