Skip to content

src: implement v8::TaskRunner API in NodePlatform #17134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 5 commits into from
Closed

src: implement v8::TaskRunner API in NodePlatform #17134

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
27f97c7
deps: cherry-pick c690f54d95802 from V8 upstream
addaleax Nov 19, 2017
d2848bb
deps: cherry-pick 98c40a4bae915 from V8 upstream
addaleax Nov 19, 2017
8be600b
src: implement v8::TaskRunner API in NodePlatform
addaleax Nov 19, 2017
2cd135b
[squash] gahaas nit
addaleax Nov 20, 2017
9bd517e
[squash] `UNREACHABLE();` all the things
addaleax Nov 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] UNREACHABLE(); all the things
  • Loading branch information
@addaleax
addaleax committed Nov 21, 2017
commit 9bd517ea6f47d63b44232dbd25ded60aa959896c
7 changes: 3 additions & 4 deletions src/node_platform.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,12 @@ void BackgroundTaskRunner::PostTask(std::unique_ptr<Task> task) {
}

void BackgroundTaskRunner::PostIdleTask(std::unique_ptr<v8::IdleTask> task) {
CHECK(false && "idle tasks not enabled");
UNREACHABLE();
}

void BackgroundTaskRunner::PostDelayedTask(std::unique_ptr<v8::Task> task,
double delay_in_seconds) {
// It's unclear whether this is required at all for background tasks.
PostTask(std::move(task));
UNREACHABLE();
}

void BackgroundTaskRunner::BlockingDrain() {
Expand Down Expand Up @@ -77,7 +76,7 @@ void PerIsolatePlatformData::FlushTasks(uv_async_t* handle) {
}

void PerIsolatePlatformData::PostIdleTask(std::unique_ptr<v8::IdleTask> task) {
CHECK(false && "idle tasks not enabled");
UNREACHABLE();
}

void PerIsolatePlatformData::PostTask(std::unique_ptr<Task> task) {
Expand Down