Skip to content

tools: enforce no unused trailing arguments tools directory #16953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

tools: enforce no unused trailing arguments tools directory #16953

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd4a515
tools: remove unused trailing function arguments
Trott Nov 9, 2017
6df6ead
tools: enforce no unused trailing arguments tools directory
Trott Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: remove unused trailing function arguments 
Update tools/doc/html.js and tools/eslint-rules/crypto-check.js to
remove unused trailing function arguments in preparation for enabling a
lint rule to enforce that practice.
  • Loading branch information
@Trott
Trott committed Nov 11, 2017
commit bd4a5155a39956b6c232b38bb9c915b9381d6be0
2 changes: 1 addition & 1 deletion tools/doc/html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ function altDocs(filename) {
const host = 'https://nodejs.org';
const href = (v) => `${host}/docs/latest-v${v.num}/api/${filename}.html`;

function li(v, i) {
function li(v) {
let html = `<li><a href="${href(v)}">${v.num}`;

if (v.lts)
Expand Down
2 changes: 1 addition & 1 deletion tools/eslint-rules/crypto-check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ module.exports = function(context) {
}
}

function reportIfMissingCheck(node) {
function reportIfMissingCheck() {
if (hasSkipCall) {
return;
}
Expand Down