Skip to content

First time contribution from NodeConf EU #16821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paulashfield wants to merge 3 commits into from
Closed

First time contribution from NodeConf EU #16821

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81cfdc6
Nodeconf is awesome first change
Nov 6, 2017
a9d7c3d
Updated test case based on feedback from @apapirovski @vsemozhetbyt a…
paulashfield Nov 7, 2017
2b1ad0a
squash: lint fix
Trott Nov 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: lint fix
  • Loading branch information
@Trott
Trott committed Nov 8, 2017
commit 2b1ad0aa44cb362455d7e14f3cb9a8d5dbfba64b
2 changes: 1 addition & 1 deletion test/addons-napi/test_general/testNapiRun.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ const expected = 42;
const actual = addon.testNapiRun(testCase);

@apapirovski apapirovski Nov 6, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be then rewritten as:

const actual = addon.testNapiRun(`(${val1} + ${val2});`);


assert.strictEqual(actual, expected);
assert.throws(() => addon.testNapiRun({abc: 'def'}), /string was expected/);
assert.throws(() => addon.testNapiRun({ abc: 'def' }), /string was expected/);