Skip to content

doc: document common pattern for instanceof checks #16699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 3 commits into from
Closed

doc: document common pattern for instanceof checks #16699

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58e47e8
doc: document common pattern for instanceof checks
mhdawson Nov 2, 2017
dc5fee6
squash: minor fixup
mhdawson Nov 2, 2017
192596f
squash: address comments
mhdawson Nov 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: minor fixup
  • Loading branch information
@mhdawson
mhdawson committed Nov 2, 2017
commit dc5fee6fd7538cca96e72643c3e2c157d306ce9c
4 changes: 2 additions & 2 deletions doc/api/n-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3028,7 +3028,7 @@ reference to the class constructor for later `instanceof` checks.

As an example:

```
```C
napi_value MyClass_constructor = nullptr;
status = napi_get_reference_value(env, MyClass::es_constructor, &MyClass_constructor);
assert(napi_ok == status);
Expand All @@ -3042,7 +3042,7 @@ if (is_instance) {
}
```

Of course you also need to make sure to free the reference once it is no longer needed.
Of course the reference must be freed once it is no longer needed.

@cjihrig cjihrig Nov 3, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop "Of course"


### *napi_define_class*
<!-- YAML
Expand Down