Skip to content

tools: add remark dependencies #16635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
watilde wants to merge 2 commits into from
Closed

tools: add remark dependencies #16635

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d77a01
tools: include remark node_modules
watilde Oct 31, 2017
f887f37
build: remove lint-md-build
watilde Oct 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build: remove lint-md-build
  • Loading branch information
@watilde
watilde committed Nov 8, 2017
commit f887f37c74a177447243c60d1e873da427312f2a
17 changes: 1 addition & 16 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,19 +971,6 @@ bench: bench-net bench-http bench-fs bench-tls

bench-ci: bench

lint-md-clean:
$(RM) -r tools/remark-cli/node_modules
$(RM) -r tools/remark-preset-lint-node/node_modules
$(RM) tools/.*mdlintstamp

lint-md-build:
@if [ ! -d tools/remark-cli/node_modules ]; then \
echo "Markdown linter: installing remark-cli into tools/"; \
cd tools/remark-cli && ../../$(NODE) ../../$(NPM) install; fi
@if [ ! -d tools/remark-preset-lint-node/node_modules ]; then \
echo "Markdown linter: installing remark-preset-lint-node into tools/"; \
cd tools/remark-preset-lint-node && ../../$(NODE) ../../$(NPM) install; fi

LINT_MD_TARGETS = src lib benchmark tools/doc tools/icu
LINT_MD_ROOT_DOCS := $(wildcard *.md)
LINT_MD_FILES := $(shell find $(LINT_MD_TARGETS) -type f \
Expand All @@ -1002,7 +989,7 @@ tools/.miscmdlintstamp: $(LINT_MD_FILES)

tools/.mdlintstamp: tools/.miscmdlintstamp tools/.docmdlintstamp

lint-md: | lint-md-build tools/.mdlintstamp
lint-md: tools/.mdlintstamp

LINT_JS_TARGETS = benchmark doc lib test tools
LINT_JS_CMD = tools/eslint/bin/eslint.js --cache \
Expand Down Expand Up @@ -1157,8 +1144,6 @@ lint-clean:
lint-js-ci \
list-gtests \
lint-md \
lint-md-build \
lint-md-clean \
pkg \
release-only \
run-ci \
Expand Down