Skip to content

Make tests engine agnostic #16272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 15 commits into from
Closed

Make tests engine agnostic #16272

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9231450
test: make test-buffer-slow engine agnostic
Trott Oct 17, 2017
12cc6c0
test: make test-cli-syntax engine agnostic
Trott Oct 17, 2017
8bde5ed
test: make test-console-count engine agnostic
Trott Oct 17, 2017
2ab4577
test: make test-console engine agnostic
Trott Oct 17, 2017
e8e6863
test: make test-error-reporting engine agnostic
Trott Oct 17, 2017
53c033c
test: make test-http-outgoing-proto agnostic
Trott Oct 17, 2017
ab32e20
test: make error stack test engine agnostic
Trott Oct 17, 2017
b64b12e
test: make test-os-eol engine agnostic
Trott Oct 17, 2017
ebc145f
test: make test-process-env-symbols agnostic
Trott Oct 17, 2017
c40983b
test: make test-querystring-escape engine agnostic
Trott Oct 17, 2017
ef2da79
test: make test-repl-harmony engine agnostic
Trott Oct 17, 2017
244cf83
test: make test-repl-syntax-error-stack agnostic
Trott Oct 17, 2017
399b292
test: make test-repl engine agnostic
Trott Oct 17, 2017
d0d2b0a
test: make test-require-json engine agnostic
Trott Oct 17, 2017
4f21368
test: make test-tls-external-accessor agnostic
Trott Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: make test-cli-syntax engine agnostic 
Do not check the error message if it is generated by the JavaScript
engine (V8, ChakraCore, etc.). Do confirm that it is a `SyntaxError`.
  • Loading branch information
@Trott
Trott committed Nov 11, 2017
commit 12cc6c0c589f51c281a1ac7f5ddf8a0b3c0e9c06
4 changes: 3 additions & 1 deletion test/parallel/test-cli-syntax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ const syntaxArgs = [
['--check']
];

const syntaxErrorRE = /^SyntaxError: Unexpected identifier$/m;
// Match on the name of the `Error` but not the message as it is different
// depending on the JavaScript engine.
const syntaxErrorRE = /^SyntaxError: \b/m;
const notFoundRE = /^Error: Cannot find module/m;

// test good syntax with and without shebang
Expand Down