Skip to content

🎨 test: include expected result in error messages #16039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keywordnew wants to merge 3 commits into from
Closed

🎨 test: include expected result in error messages #16039

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85682d3
test: include expected result in error messages
keywordnew Oct 6, 2017
20efb5a
test: include actual result in error messages
keywordnew Oct 7, 2017
07c70cc
test: fix linter errors
keywordnew Oct 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions test/doctool/test-doctool-html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,18 +115,19 @@ testData.forEach((item) => {
assert.ifError(err);

const actual = output.replace(spaces, '');
const scriptDomain = 'google-analytics.com'
// Assert that the input stripped of all whitespace contains the
// expected list
assert(actual.includes(expected));

// Testing the insertion of Google Analytics script when
// an analytics id is provided. Should not be present by default
if (includeAnalytics) {
assert(actual.includes('google-analytics.com'),
'Google Analytics script was not present');
assert(actual.includes(scriptDomain),
'Google Analytics script was not present, but it should be');

@BridgeAR BridgeAR Oct 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea here is to include the actual value and not only to change the message.
So it should actually be like

assert(actual.includes(scriptDomain),
           `Google Analytics script was not present in "${actual}"`);

@gibfahn gibfahn Oct 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chowdhurian could you push a commit to this branch that makes the change @BridgeAR suggested? LGTM with those changes.

} else {
assert.strictEqual(actual.includes('google-analytics.com'), false,
'Google Analytics script was present');
assert.strictEqual(actual.includes(scriptDomain), false,
'Google Analytics script was present, but it should not be');
}
}));
}));
Expand Down