Skip to content

test: replaced common.fixturesDir with common.fixtures module usage #15933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
letthewookieewin wants to merge 4 commits into from
Closed

test: replaced common.fixturesDir with common.fixtures module usage #15933

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c32885
test: replaced common.fixturesDir with common.fixtures module usage
letthewookieewin Oct 6, 2017
535cd51
test: replaced common.fixturesDir with common.fixtures module
letthewookieewin Oct 6, 2017
ddc5cf2
test: removed fs import since no longer needed
letthewookieewin Oct 6, 2017
8e0efc5
test: changed readSync to readKey for the cert for consistency
letthewookieewin Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: replaced common.fixturesDir with common.fixtures module usage
  • Loading branch information
@letthewookieewin
letthewookieewin committed Oct 6, 2017
commit 2c328859e0cad67559e30845ad4469ffc86aa8e8
5 changes: 3 additions & 2 deletions test/parallel/test-https-client-get-url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

'use strict';
const common = require('../common');
const fixtures = require('../common/fixtures');
if (!common.hasCrypto)
common.skip('missing crypto');

Expand All @@ -35,8 +36,8 @@ const url = require('url');
const URL = url.URL;

const options = {
key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`),
cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`)
key: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-key.pem`),

@pawelgolda pawelgolda Oct 6, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be using method fixtures.readKey instead of fs.readFileSync to get the keys.

@letthewookieewin letthewookieewin Oct 6, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Updated to use fixtures.readKey and fixtures.readSync (for the cert).

cert: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-cert.pem`)
};

const server = https.createServer(options, common.mustCall((req, res) => {
Expand Down