Skip to content

build: call setlocal in vcbuild.bat #15754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 1 commit into from
Closed

build: call setlocal in vcbuild.bat #15754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: call setlocal in vcbuild.bat 
Currently the variables set in vcbuild.bat are mostly global and
escape/leak out into the calling process. For example, running
vcbuild.bat test and then echoing the config variable gives:

vcbuild.bat test
...
echo %config%
Release

After this change the same command give:
vcbuild.bat test
...
echo %config%
%config%
  • Loading branch information
@danbev
danbev committed Oct 2, 2017
commit 2362c252c666991b9ca6a0074a224faaeff5d054
2 changes: 2 additions & 0 deletions vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
@echo off

setlocal EnableExtensions

cd %~dp0

if /i "%1"=="help" goto help
Expand Down