Skip to content

dgram: add source-specific multicast support #15735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LPardue wants to merge 9 commits into from
Closed

dgram: add source-specific multicast support #15735

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2b6b1ac
dgram: add source-specific multicast support
Oct 2, 2017
b36f53c
Update dgram.md
Trott Oct 15, 2019
6ea4a7b
Update test-dgram-multicast-ssm-multi-process.js
Trott Oct 15, 2019
94f7449
Update test-dgram-multicast-ssmv6-multi-process.js
Trott Oct 15, 2019
f75fd45
Update test-dgram-multicast-ssmv6-multi-process.js
Trott Oct 15, 2019
f271357
Check iface for null, not group_address
n-thumann Oct 11, 2019
4392ebf
Check iface against nullptr
addaleax Oct 16, 2019
b049b3a
Fix optional argument format in docs
addaleax Oct 16, 2019
888dc05
Fixes two deprecation warnings
n-thumann Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check iface for null, not group_address
  • Loading branch information
@n-thumann @addaleax
n-thumann authored and addaleax committed Oct 16, 2019
commit f2713577bb2ffc1e84d9f227e36e78cdfb072d33
2 changes: 1 addition & 1 deletion src/udp_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ void UDPWrap::SetSourceMembership(const FunctionCallbackInfo<Value>& args,
node::Utf8Value iface(args.GetIsolate(), args[2]);

const char* iface_cstr = *iface;
Comment thread
addaleax marked this conversation as resolved.
Outdated
if (args[1]->IsUndefined() || args[1]->IsNull()) {
if (args[2]->IsUndefined() || args[2]->IsNull()) {
Comment thread
addaleax marked this conversation as resolved.
Outdated
iface_cstr = nullptr;
}

Expand Down