Skip to content

util: use faster -0 check #15726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mscdex merged 1 commit into from
Oct 4, 2017
Merged

util: use faster -0 check #15726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
util: use faster -0 check 
PR-URL: #15726
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
  • Loading branch information
@mscdex
mscdex committed Oct 4, 2017
commit d545c948c238f66cf673f156983b7c1b18b4bf28
6 changes: 5 additions & 1 deletion benchmark/util/inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ const bench = common.createBenchmark(main, {
'Error',
'Array',
'TypedArray',
'TypedArray_extra'
'TypedArray_extra',
'Number'
],
option: Object.keys(opts)
});
Expand Down Expand Up @@ -92,6 +93,9 @@ function main({ method, n, option }) {
obj[Symbol('baz')] = 5;
benchmark(n, obj, options);
break;
case 'Number':
benchmark(n, 0, options);
break;
default:
throw new Error(`Unsupported method "${method}"`);
}
Expand Down
6 changes: 4 additions & 2 deletions lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,8 +615,10 @@ function formatValue(ctx, value, recurseTimes, ln) {
}

function formatNumber(fn, value) {
// Format -0 as '-0'. Strict equality won't distinguish 0 from -0.
if (Object.is(value, -0))
// Format -0 as '-0'. A `value === -0` check won't distinguish 0 from -0.
// Using a division check is currently faster than `Object.is(value, -0)`
// as of V8 6.1.
if (1 / value === -Infinity)
return fn('-0', 'number');
return fn(`${value}`, 'number');
}
Expand Down