Skip to content

stream: fix disparity between buffer and the count #15661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jlvivero wants to merge 2 commits into from
Closed

stream: fix disparity between buffer and the count #15661

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c83509
stream: fix disparity between buffer and the count
jlvivero Sep 28, 2017
728405d
change comment style
jlvivero Sep 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
change comment style
  • Loading branch information
@jlvivero
jlvivero committed Sep 28, 2017
commit 728405da2886066c5961f0757ae4d5b26315e60b
8 changes: 4 additions & 4 deletions test/sequential/test-stream-writable-clear-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';
const common = require('../common');
const Stream = require('stream');
//this test ensures that the _writeableState.bufferedRequestCount and
// This test ensures that the _writeableState.bufferedRequestCount and
// the actual buffered request count are the same
const assert = require('assert');

Expand All @@ -10,9 +10,9 @@ class StreamWritable extends Stream.Writable {
super({ objectMode: true });
}

//We need a timeout like on the original issue thread
//otherwise the code will never reach our test case
//this means this should go on the sequential folder.
// We need a timeout like on the original issue thread
// otherwise the code will never reach our test case
// this means this should go on the sequential folder.
_write(chunk, encoding, cb) {
setTimeout(cb, common.platformTimeout(10));
}
Expand Down