Skip to content

src: use UV_EINVAL instead of EINVAL in udp_wrap #15444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 5 commits into from
Closed

src: use UV_EINVAL instead of EINVAL in udp_wrap #15444

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b06909f
src: use UV_EINVAL instead of EINVAL in udp_wrap
danbev Sep 17, 2017
5178868
squash: add test for recv/send buffer sizes
danbev Sep 17, 2017
2a76b64
squash: use string instread of a regexp
danbev Sep 18, 2017
dfc29b2
squash: use string template
danbev Sep 18, 2017
b87360c
squash: remove eslint ignore rule
danbev Sep 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: add test for recv/send buffer sizes
  • Loading branch information
@danbev
danbev committed Sep 20, 2017
commit 517886867406245136c506acce7a070fbeb6873b
22 changes: 22 additions & 0 deletions test/parallel/test-dgram-socket-buffer-size.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,25 @@ const dgram = require('dgram');
socket.close();
}));
}

function checkBufferSizeError(type, size) {
const errorObj = {
code: 'ERR_SOCKET_BUFFER_SIZE',
type: Error,
message: new RegExp('^Could not get or set buffer' +
' size: Error: EINVAL: invalid argument,' +
' uv_' + type + '_buffer_size$')

@tniessen tniessen Sep 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I believe a string (instead of a regex) is enough to get exact matching here. You might want to use a template string instead of concatenation, I think we agreed on that preference.

@danbev danbev Sep 18, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually used a template for this but the linter complained which is why I changed it. I'll take another look though.

@tniessen tniessen Sep 18, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually use templates, except if the line becomes too long, in that case you can concatenate templates and string literals:

'Could not get or set buffer size: Error: EINVAL: ' +
`invalid argument, uv_${type}_buffer_size`

@danbev danbev Sep 19, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated now.

};
const functionName = 'set' + type.charAt(0).toUpperCase() +
type.slice(1) + 'BufferSize';
const socket = dgram.createSocket('udp4');
socket.bind(common.mustCall(() => {
assert.throws(() => {
socket[functionName](size);
}, common.expectsError(errorObj));
socket.close();
}));
}

checkBufferSizeError('recv', 2147483648);
checkBufferSizeError('send', 2147483648);