Skip to content

Link to correct "OS Constants" heading in docs #14969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamiebuilds wants to merge 2 commits into from
Closed

Link to correct "OS Constants" heading in docs #14969

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2712716
Link to correct "OS Constants" heading in docs
jamiebuilds Aug 21, 2017
845d9de
[Squash]: Use parens
jasnell Aug 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/api/os.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ added: v6.3.0

Returns an object containing commonly used operating system specific constants
for error codes, process signals, and so on. The specific constants currently
defined are described in [OS Constants][].
defined are described in [OS Constants][#os_os_constants_1].

@TimothyGu TimothyGu Aug 22, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be parentheses around the URL?

@jasnell jasnell Aug 23, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimothyGu, I can correct that upon landing. ... scratch that, I just pushed a commit to the branch directly fixing that.


## os.cpus()
<!-- YAML
Expand Down