Skip to content

v8: fix debug builds on Windows #13634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bzoz wants to merge 1 commit into from
Closed

v8: fix debug builds on Windows #13634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
v8: fix debug builds on Windows 
Adds missing return which fixes debug builds on Windows

Fixes: #13392
  • Loading branch information
@bzoz
bzoz committed Jun 12, 2017
commit 2e2268fee43f7da9ae1b250b50990d2a1f1b5237
5 changes: 4 additions & 1 deletion deps/v8/src/api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,10 @@ void V8::SetSnapshotDataBlob(StartupData* snapshot_blob) {
i::V8::SetSnapshotBlob(snapshot_blob);
}

void* v8::ArrayBuffer::Allocator::Reserve(size_t length) { UNIMPLEMENTED(); }
void* v8::ArrayBuffer::Allocator::Reserve(size_t length) {
UNIMPLEMENTED();
return nullptr;
}

void v8::ArrayBuffer::Allocator::Free(void* data, size_t length,
AllocationMode mode) {
Expand Down