Skip to content

test: check inspector support in test/inspector #13324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 1 commit into from
Closed

test: check inspector support in test/inspector #13324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: check inspector support in test/inspector 
When configuring node --without-ssl or --without-inspector these test
will fail. The underlying issue will be:

Inspector support is not available with this Node.js build
/work/nodejs/node/out/Release/node: bad option: --inspect=0

This commit adds checks to see if inspector support is enabled and if
not skips these tests.
  • Loading branch information
@danbev
danbev committed May 31, 2017
commit 8e7ba6ff1845dae31293b308fb1492929736bdde
1 change: 1 addition & 0 deletions test/inspector/test-inspector-port-zero-cluster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
'use strict';

const common = require('../common');
common.skipIfInspectorDisabled();
const assert = require('assert');
const cluster = require('cluster');

Expand Down
3 changes: 2 additions & 1 deletion test/inspector/test-inspector-port-zero.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

const { mustCall } = require('../common');
const { mustCall, skipIfInspectorDisabled } = require('../common');
skipIfInspectorDisabled();
const assert = require('assert');
const { URL } = require('url');
const { spawn } = require('child_process');
Expand Down