Skip to content

test: update test for url.parse() to match the exact error through re… #12879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreicioromila wants to merge 3 commits into from
Closed

test: update test for url.parse() to match the exact error through re… #12879

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
411cf56
test: update test for url.parse() to match the exact error through re…
andreicioromila May 7, 2017
5b86bd5
test: allign the function and regexp vertically to keep lines short
andreicioromila May 7, 2017
ef07ba4
test: add function and symbol validation for url.parse()
andreicioromila May 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: update test for url.parse() to match the exact error through re… 
…gexp check
  • Loading branch information
@andreicioromila
andreicioromila committed May 7, 2017
commit 411cf560c930571aebc7979304d34e04564fbb6d
6 changes: 3 additions & 3 deletions test/parallel/test-url-parse-invalid-input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ const url = require('url');
0,
[],
{}

@TimothyGu TimothyGu May 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add symbols while at it?

@andreicioromila andreicioromila May 10, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved

].forEach(function(val) {
assert.throws(function() { url.parse(val); }, TypeError);
].forEach((val) => {
assert.throws(() => { url.parse(val); }, /^TypeError: Parameter "url" must be a string, not undefined|boolean|number|object$/);

@addaleax addaleax May 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to group undefined|boolean|number|object in parentheses, right?
And could you also wrap at the , (align the function and the regexp vertically)? We try to keep lines under 80 characters – for regexps that’s not always possible, but it would still be nice to try and keep lines short :)

@andreicioromila andreicioromila May 7, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have included the suggested changes

});

assert.throws(function() { url.parse('http://%E0%A4%A@fail'); }, /^URIError: URI malformed$/);
assert.throws(() => { url.parse('http://%E0%A4%A@fail'); }, /^URIError: URI malformed$/);

@jasnell jasnell May 9, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this one is still long. I'm fine with the inline regex being whitelisted, but I think if there are multiple arguments we should still try to split them by line to avoid the long lines if possible.

@andreicioromila andreicioromila May 10, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved