Skip to content

build: make configure print statements consistent #12176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 3 commits into from
Closed

build: make configure print statements consistent #12176

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7ce117
build: make configure print statements consistent
danbev Apr 3, 2017
8427409
remove leading space from write statements
danbev Apr 4, 2017
5503795
change sys.stdout.write to print
danbev Apr 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove leading space from write statements
  • Loading branch information
@danbev
danbev committed Apr 4, 2017
commit 842740948d494758d5abcf4be3bc50da399315f2
2 changes: 1 addition & 1 deletion configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,7 +1047,7 @@ def configure_intl(o):
else:
print('Re-using existing %s' % targetfile)
if os.path.isfile(targetfile):
sys.stdout.write(' Checking file integrity with MD5:\r')
sys.stdout.write('Checking file integrity with MD5:\r')

@richardlau richardlau Apr 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't object if this was changed to use print for consistency.

gotmd5 = nodedownload.md5sum(targetfile)
print('MD5: %s %s' % (gotmd5, targetfile))
if (md5 == gotmd5):
Expand Down