Skip to content

test: performance - remove Popen(shell=True) on windows #12138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 1 commit into from
Closed

test: performance - remove Popen(shell=True) on windows #12138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: performance - remove Popen(shell=True) on Windows 
not needed according to official python docs - https://docs.python.org/2/library/subprocess.html#index-2
  • Loading branch information
@refack
refack committed Mar 30, 2017
commit c2362482f090db3b24c32057d72be3fa6404d261
1 change: 0 additions & 1 deletion tools/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,6 @@ def RunProcess(context, timeout, args, **rest):
pty_out = rest.pop('pty_out')

process = subprocess.Popen(
shell = utils.IsWindows(),
args = popen_args,
**rest
)
Expand Down