Skip to content

v4.x Backport - test: don't connect to :: (use localhost instead) #11740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gibfahn wants to merge 1 commit into from
Closed

v4.x Backport - test: don't connect to :: (use localhost instead) #11740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: don't connect to :: (use localhost instead) 
If a test does http.listen(0) or net.listen(0),
http.listen(0).address().address returns '::'. Some machines will
resolve this to localhost, but not all. Every machine should have
localhost defined in /etc/hosts (or equivalent), so it should always
resolve.

Fixes: #7291
  • Loading branch information
@gibfahn
gibfahn committed Mar 8, 2017
commit ef8556e68162e8c5e614ebd487a2d48770bb4a86
2 changes: 1 addition & 1 deletion test/gc/test-net-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function getall() {
return;

(function() {
var req = net.connect(server.address().port, server.address().address);
var req = net.connect(server.address().port);
req.resume();
req.setTimeout(10, function() {
//console.log('timeout (expected)')
Expand Down
4 changes: 1 addition & 3 deletions test/parallel/test-http-status-reason-invalid-chars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
const common = require('../common');
const assert = require('assert');
const http = require('http');
const net = require('net');

function explicit(req, res) {
assert.throws(() => {
Expand Down Expand Up @@ -34,8 +33,7 @@ const server = http.createServer((req, res) => {
implicit(req, res);
}
}).listen(0, common.mustCall(() => {
const addr = server.address().address;
const hostname = net.isIPv6(addr) ? `[${addr}1]` : addr;
const hostname = 'localhost';
const url = `http://${hostname}:${server.address().port}`;
let left = 2;
const check = common.mustCall((res) => {
Expand Down